Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36438 )
Change subject: sb/intel/common: Remove the SOUTHBRIDGE_INTEL_COMMON Kconfig symbol ......................................................................
Patch Set 5:
Sadly it seems that "guard" is imperfect - this commit is causing an error for AMD boards if USBDEBUG is enabled: ... CC bootblock/lib/version.o CC bootblock/southbridge/amd/agesa/hudson/enable_usbdebug.o CC bootblock/southbridge/intel/common/usb_debug.o CC bootblock/superio/ite/common/early_serial.o LINK cbfs/fallback/bootblock.debug /home/owner/tmp/coreboot/util/crossgcc/xgcc/bin/i386-elf-ld.bfd: build/bootblock/southbridge/intel/common/usb_debug.o: in function `pci_ehci_dbg_dev': /home/owner/tmp/coreboot/src/southbridge/intel/common/usb_debug.c:35: multiple definition of `pci_ehci_dbg_dev'; build/bootblock/southbridge/amd/agesa/hudson/enable_usbdebug.o:/home/owner/tmp/coreboot/src/southbridge/amd/agesa/hudson/enable_usbdebug.c:29: first defined here /home/owner/tmp/coreboot/util/crossgcc/xgcc/bin/i386-elf-ld.bfd: build/bootblock/southbridge/intel/common/usb_debug.o: in function `pci_ehci_dbg_set_port': /home/owner/tmp/coreboot/src/southbridge/intel/common/usb_debug.c:51: multiple definition of `pci_ehci_dbg_set_port'; build/bootblock/southbridge/amd/agesa/hudson/enable_usbdebug.o:/home/owner/tmp/coreboot/src/southbridge/amd/agesa/hudson/enable_usbdebug.c:43: first defined here make: *** [src/arch/x86/Makefile.inc:177: build/cbfs/fallback/bootblock.debug] Error 1