Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33583 ) Change subject: mb/google/hatch: Do not pull down GPP_F2 internally ...................................................................... Patch Set 2: -Code-Review (1 comment) https://review.coreboot.org/#/c/33583/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c: https://review.coreboot.org/#/c/33583/2/src/mainboard/google/hatch/variants/... PS2, Line 463: DN_20K
Please help set NONE as well. Thanks. Good catch.
-- To view, visit https://review.coreboot.org/c/coreboot/+/33583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie218657fd9dde113ab26cf5551d1dff1b6e392b6 Gerrit-Change-Number: 33583 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Chen <philipchen@google.com> Gerrit-Reviewer: David Wu <david_wu@quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Philip Chen <philipchen@google.com> Gerrit-Reviewer: Shelley Chen <shchen@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Wed, 19 Jun 2019 03:13:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: David Wu <david_wu@quanta.corp-partner.google.com> Gerrit-MessageType: comment