Attention is currently required from: Paul Menzel.

Nicholas Sudsgaard uploaded patch set #7 to this change.

View Change

The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins)

device/azalia: Rework the verb table

This is a very experimental change and I would appreciate anyone's
opinion on this. :)

My intentions are to make verb tables cleaner on the both the
configuration and implementation side.

On the configuration side (i.e. hda_verbs.c) this method removes most
superfluous comments (e.g. /* Subsystem ID */) and makes it more
"structured".

On the implementation side I tried to make it easier to read (and
hopefully maintain). For example, compare azalia_find_verb() and
azalia_find_verb_table(). I also got rid of global variables (but
introduced including c source files directly instead...).

Change-Id: If8b672e4fd800b34e5ba39fad174fcf1154b0a54
Signed-off-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
---
M src/device/azalia_device.c
M src/include/device/azalia_device.h
A src/include/device/azalia_table_exporter.c
M src/mainboard/hp/snb_ivb_laptops/variants/2560p/hda_verb.c
4 files changed, 113 insertions(+), 103 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/80333/7

To view, visit change 80333. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If8b672e4fd800b34e5ba39fad174fcf1154b0a54
Gerrit-Change-Number: 80333
Gerrit-PatchSet: 7
Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: newpatchset