Shelley Chen uploaded patch set #2 to this change.

View Change

soc/intel/cannonlake: Use MEM_CH_SEL to initialize MemorySpdPrts

MEM_CH_SEL is used to indicate whether we are on a single or dual
channel device, where MEM_CH_SEL = 1 for single channel skus and
MEM_CH_SEL = 0 for dual channel skus. Initialize MemorySpdPrt
pointers based on the value read from MEM_CH_SEL, which is read from
GPP_F2. In the first build, we did not use GPP_F2, so we need to add
an internal pulldown as those early devices were all dual channel
devices.

BUG=b:123062346, b:122959294
BRANCH=None
TEST=Boot into current boards and ensure that we have 2 channels as expected
Also, verify that GPP_F2 is set to 0.

Change-Id: Ice22b103664187834e255d1359bfd9b51993b5b6
Signed-off-by: Shelley Chen <shchen@google.com>
---
M src/mainboard/google/hatch/variants/baseboard/gpio.c
M src/soc/intel/cannonlake/cnl_memcfg_init.c
2 files changed, 16 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/31262/2

To view, visit change 31262. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice22b103664187834e255d1359bfd9b51993b5b6
Gerrit-Change-Number: 31262
Gerrit-PatchSet: 2
Gerrit-Owner: Shelley Chen <shchen@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Shelley Chen <shchen@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: newpatchset