Patch Set 4:

So which commit is the S3 regression fix?

There are 2+ more things wrong with the psp-verstage build. One of them building PCI code into psp-verstage, although on a codepath that should not ever be reached. One of them the build just failing when psp-verstage using the option visible in menuconfig.

Sorry for not posting the link earlier. It was late and I just wanted to make sure this didn't get merged. https://review.coreboot.org/c/coreboot/+/43334/1

View Change

To view, visit change 43066. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic086c60d8e6edc9c0dff65e2569999a314c7c4ba
Gerrit-Change-Number: 43066
Gerrit-PatchSet: 4
Gerrit-Owner: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Eric Peers <epeers@google.com>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Fri, 10 Jul 2020 14:54:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment