I'm puzzled by the file in `vendorcode/`, isn't that usually
code written by the vendor? Can't we just move everything
into `util/smc/Makefile.inc`?

View Change

2 comments:

• File util/smc/smcbiosinfo/smcbiosinfo.c:

  • Patch Set #9, Line 100: ret = 0;

    Usually it counts as failure, 0 should only be returned if the tool did it's job.

  • Patch Set #9, Line 164: memcpy(&sbu.boardid[1], CONFIG_SUPERMICRO_BOARDID, strlen(CONFIG_SUPERMICRO_BOARDID));

    this can overflow, how about MIN(sizeof(sbu.boardid) - 1, ...)

To view, visit change 35484. To unsubscribe, or for help writing mail filters, visit settings.