not sure, suspect it may be related to the Apple SMC emulation / Hackintosh support that mjg59 was also working on at the time. I can pull it, just need to find a tester to validate before merging

yeah, that might be the case here. i'd like to not have this in this patch, since i'm not sure if the smi handler really exists or if it just crashes/misbehaves/... if you've checked that that won't cause any issues, i'd also be ok with it still in this patch, but i'd prefer if it wasn't

View Change

To view, visit change 32531. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If74621e76d703f629b54f1feb1acfc95cc72d183
Gerrit-Change-Number: 32531
Gerrit-PatchSet: 41
Gerrit-Owner: Matthew Garrett <mjg59@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Matthew Garrett <mjg59@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-CC: Christian Walter <christian.walter@9elements.com>
Gerrit-CC: Felix Held <felix-coreboot@felixheld.de>
Gerrit-CC: Maxim Polyakov <max.senia.poliak@gmail.com>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sat, 14 Mar 2020 22:58:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment