Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Nick Vaccaro: Looks good to me, approved Tim Wawrzynczak: Looks good to me, but someone else must approve
mb/google/volteer: update thermal table for Eldrid

1. Add pl4 value
2. Change policies passive with sensor 0 and 1
3. Change granularity value with pl1 and pl2

BUG=b:178768749
TEST=make buildall

Signed-off-by: Nick Chen <nick_xr_chen@wistron.corp-partner.google.com>
Change-Id: I2f1fe9a6de4dbb587b79cb8758c5458a3ae5d768
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50111
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/mainboard/google/volteer/variants/eldrid/overridetree.cb
1 file changed, 13 insertions(+), 11 deletions(-)

diff --git a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb
index 37e0ab9..6760361 100644
--- a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb
@@ -3,10 +3,12 @@
register "power_limits_config[POWER_LIMITS_U_2_CORE]" = "{
.tdp_pl1_override = 15,
.tdp_pl2_override = 51,
+ .tdp_pl4 = 71,
}"
register "power_limits_config[POWER_LIMITS_U_4_CORE]" = "{
.tdp_pl1_override = 15,
.tdp_pl2_override = 51,
+ .tdp_pl4 = 105,
}"

register "tcc_offset" = "5" # TCC of 95
@@ -98,27 +100,27 @@
register "policies.active" = "{[0] = {.target=DPTF_NONE}}"

## Passive Policy
- register "policies.passive[0]" = "DPTF_PASSIVE(CPU,CPU,95,5000)"
- register "policies.passive[1]" = "DPTF_PASSIVE(CPU,TEMP_SENSOR_2,60,6000)"
+ register "policies.passive[0]" = "DPTF_PASSIVE(CPU,CPU,87,5000)"
+ register "policies.passive[1]" = "DPTF_PASSIVE(CPU,TEMP_SENSOR_2,60.8,6000)"

## Critical Policy
register "policies.critical[0]" = "DPTF_CRITICAL(CPU,100,SHUTDOWN)"
- register "policies.critical[1]" = "DPTF_CRITICAL(TEMP_SENSOR_2,80,SHUTDOWN)"
+ register "policies.critical[1]" = "DPTF_CRITICAL(TEMP_SENSOR_2,75,SHUTDOWN)"

## Power Limits Control
- # 3-15W PL1 in 200mW increments, avg over 28-32s interval
- # PL2 is fixed at 51W, avg over 28-32s interval
+ # 3-15W PL1 in 200mW increments, avg over 26-34s interval
+ # PL2 is fixed at 51W, avg over 26-34s interval
register "controls.power_limits" = "{
.pl1 = {.min_power = 3000,
.max_power = 15000,
- .time_window_min = 28 * MSECS_PER_SEC,
- .time_window_max = 32 * MSECS_PER_SEC,
- .granularity = 200,},
+ .time_window_min = 26 * MSECS_PER_SEC,
+ .time_window_max = 34 * MSECS_PER_SEC,
+ .granularity = 250,},
.pl2 = {.min_power = 51000,
.max_power = 51000,
- .time_window_min = 28 * MSECS_PER_SEC,
- .time_window_max = 32 * MSECS_PER_SEC,
- .granularity = 1000,}}"
+ .time_window_min = 26 * MSECS_PER_SEC,
+ .time_window_max = 34 * MSECS_PER_SEC,
+ .granularity = 250,}}"

device generic 0 on end
end

To view, visit change 50111. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2f1fe9a6de4dbb587b79cb8758c5458a3ae5d768
Gerrit-Change-Number: 50111
Gerrit-PatchSet: 4
Gerrit-Owner: Nick Chen <nick_xr_chen@wistron.corp-partner.google.com>
Gerrit-Reviewer: Keith Short <keithshort@chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Anfernee Chen <anfernee_chen@wistron.corp-partner.google.com>
Gerrit-CC: Casper Chang <casper_chang@wistron.corp-partner.google.com>
Gerrit-CC: Malik Hsu <malik_hsu@wistron.corp-partner.google.com>
Gerrit-CC: Mark Hsieh <mark_hsieh@wistron.corp-partner.google.com>
Gerrit-CC: Scott Chao <scott_chao@wistron.corp-partner.google.com>
Gerrit-MessageType: merged