Will post an update once I am finish dealing with the CamelCase. Not until the middle of next week.

View Change

17 comments:

• File src/security/intel/stm/SmmStm.c:

  • Patch Set #6, Line 369: //

    whitespace at begging of line […]

    I assume that you mean that all comments are to be left justified. Coding style and the bot were not clear on that issue. Will mode all files to comply.

  • Patch Set #6, Line 439: for (SubIndex = 0;

    suspect code indent for conditional statements (24, 24)

    Done

  • Patch Set #6, Line 442: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice >

    try to use functions if the indentation is too much

    Done

  • Patch Set #6, Line 442: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice >

    Done

    Done

  • Patch Set #6, Line 442: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice >

    suspect code indent for conditional statements (24, 40)

    Done

  • Patch Set #6, Line 442: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice >

    Done

    Done

  • Patch Set #6, Line 444: (Resource->PciCfg.PciDevicePath[SubIndex].PciFunction >

    How does one deal with statements that cannot be split

    Done

  • Patch Set #6, Line 748: (STM_PAGES_TO_SIZE(STM_SIZE_TO_PAGES(StmHeader->SwStmHdr.StaticImageSize))

    How does one deal with statements that really cannot be split

    Done

  • Patch Set #6, Line 750: + (StmHeader->SwStmHdr.PerProcDynamicMemorySize

    trailing whitespace

    Done

  • Patch Set #6, Line 750: + (StmHeader->SwStmHdr.PerProcDynamicMemorySize

    Done

    Done

  • Patch Set #6, Line 750: + (StmHeader->SwStmHdr.PerProcDynamicMemorySize

    Done

    Done

  • Patch Set #6, Line 791: uint32_t

    uintptr_t

    Done

• File src/security/intel/stm/StmPlatformResource.c:

  • Patch Set #6, Line 38: void FixupPciexResource(void);

    looks like those can be made static. […]

    Done

  • Patch Set #6, Line 186: //RscPcieMmio.Base = PcdGet64 (PcdPciExpressBaseAddress);

    CONFIG_MMCONF_BASE_ADDRESS […]

    Done

• File src/security/intel/stm/StmPlatformSmm.c:

  • Patch Set #6, Line 53: printk(BIOS_DEBUG, "STM loaded into mseg: 0x%08x size: %u\n",

    %p

    Done

  • Patch Set #6, Line 54: (uint32_t) MsegBase, StmImageSize);

    remove case

    Done

  • Patch Set #6, Line 87: void ReadGdtr(struct descriptor *gdtr)

    static

    Done

To view, visit change 33234. To unsubscribe, or for help writing mail filters, visit settings.