View Change

1 comment:

• File src/soc/intel/cannonlake/uart.c:

  • Patch Set #1, Line 61: return (struct device *)pcidev_path_on_root(PCH_DEVFN_UART0);

    why do you need a cast here? seems fishy.

    That is to only drop the const qualifier from pcidev_path_on_root return data. Or else the function return type needs to be revised to const struct device * and then the entire dependent functions(consumers) also needs to be align to revised return type.

To view, visit change 34582. To unsubscribe, or for help writing mail filters, visit settings.