1 comment:
File src/mainboard/intel/elkhartlake_crb/variants/ehlcrb/gpio.c:
Patch Set #6, Line 20: return gpio_table;
> Why not just using `gpio_configure_pads(pads, num)` here? […]
I am doing it like that in my boards, for example clevo/cml-u. I just think it makes more sense to call gpio_configure_pads() here instead of returning a pointer and then calling it. So it's one less step. Hence the suggestion to rename the methods. So in common code you would just call configure_gpios() or configure_early_gpios() then.
However, I don't mind if you want to do the GPIO configuration this way. That's just my opinion.
To view, visit change 47707. To unsubscribe, or for help writing mail filters, visit settings.