Lean Sheng Tan uploaded patch set #4 to this change.

View Change

mb/intel/coffeelake_rvp: Fix display issues on CFL-H, CFL-S, WHL
Intel RVP

This patch fixes display issues on both CFL-H & S, and WHL Intel RVP
platform where display are not showing up in UEFI shell, by configuring
DDi ports in device tree.

This patches also fixes no eDP display observed in UEFI shell on UEFI
Payload. Root cause is eDP requires minimum delay between GPIO
programming and eDP initialization, which was not sufficient during
FSP-S which causes VBT to return error during eDP init.
This issue is fixed by programming eDP GPIO's in bootblock stage and
skipping FSP GPIO programming by setting 'DdiPortEdp=0' in devicetree.

TEST= verified eDP display, HDMI and DP functionalities on CFL-H, CFL-S
& WHL Intel RVP platforms.

Signed-off-by: Lean Sheng Tan <lean.sheng.tan@intel.com>
Change-Id: Iee87649492f7803210f9a35cd46b4f9826cbc93c
---
M src/mainboard/intel/coffeelake_rvp/variants/baseboard/gpio.c
M src/mainboard/intel/coffeelake_rvp/variants/cfl_h/devicetree.cb
M src/mainboard/intel/coffeelake_rvp/variants/cfl_s/devicetree.cb
M src/mainboard/intel/coffeelake_rvp/variants/whl_u/devicetree.cb
4 files changed, 51 insertions(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/34159/4

To view, visit change 34159. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iee87649492f7803210f9a35cd46b4f9826cbc93c
Gerrit-Change-Number: 34159
Gerrit-PatchSet: 4
Gerrit-Owner: Lean Sheng Tan <lean.sheng.tan@intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com>
Gerrit-Reviewer: Boon Tiong Teo <boon.tiong.teo@intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Lean Sheng Tan <lean.sheng.tan@intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela@intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: newpatchset