Attention is currently required from: Arthur Heymans, Chen, Gang C, Christian Walter, David Hendricks, Jincheng Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Nico Huber, Patrick Rudolph, TangYiwei, Tim Chu.

View Change

4 comments:

• File src/soc/intel/xeon_sp/chip_gen6.c:

  • Patch Set #18, Line 145: soc_create_fsp24_domains(dp, upstream, sr, DOMAIN_TYPE_IOAT, pci_segment_group);

    This will work, but I realized that in SPR, the domain names will be conflict with the static SSDT A […]

    Since the code base changes a lot. Let me close this first and please open new discussion if any. Thanks!

• File src/soc/intel/xeon_sp/chip_gen6.c:

  • Patch Set #21, Line 34: }

    Note, you could avoid the late HOB lookup by adding the resources already […]

    Good suggestion, I will have a patch to modify gen1 and gen6 together for this.

  • Patch Set #21, Line 57: res->flags = IORESOURCE_SUBTRACTIVE;

    In hardware, there's virtually always only one subtractive resource of a type. […]

    You are right. This is a bug, fixed.

  • Patch Set #21, Line 119: void iio_pci_domain_read_resources(struct device *dev)

    Why is this an external API?

    Good catch, fixed.

To view, visit change 81316. To unsubscribe, or for help writing mail filters, visit settings.