Attention is currently required from: Felix Held, Marshall Dawson, Martin Roth, Zheng Bao.

Bao Zheng uploaded patch set #6 to this change.

View Change

The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins)

amdfwtool: Move code related to getting options to a new file

Cleanup the messy code. The code left in main is all about filling
tables.

To help to do this,
1. Some local variables are put into global struct.
2. Add some functions. Set some functions to global.

TEST=Identical test on all AMD platforms

Change-Id: Ia25c3fd5de7ae48054359f0f6551d91d7a4f6828
Signed-off-by: Zheng Bao <fishbaozi@gmail.com>
---
M util/amdfwtool/Makefile
M util/amdfwtool/Makefile.mk
M util/amdfwtool/amdfwtool.c
M util/amdfwtool/amdfwtool.h
A util/amdfwtool/opts.c
5 files changed, 796 insertions(+), 761 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/78311/6

To view, visit change 78311. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia25c3fd5de7ae48054359f0f6551d91d7a4f6828
Gerrit-Change-Number: 78311
Gerrit-PatchSet: 6
Gerrit-Owner: Bao Zheng <fishbaozi@gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Martin Roth <martin.roth@amd.corp-partner.google.com>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Martin Roth <martin.roth@amd.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de>
Gerrit-MessageType: newpatchset