Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/70278 )
(
15 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: drivers/pc80/vga: Add legacy VGA romstage support ......................................................................
drivers/pc80/vga: Add legacy VGA romstage support
This is support for adding legacy VGA support into romstage. Support for this is being provided by libgfxinit.
The current use case allows us to initialize the display before memory init (prior to physical memory init) to inform the user when lengthy memory training is needed.
BUG=b:252792591 BRANCH=firmware-brya-14505.B TEST=VGA code compiles for romstage
Change-Id: I81309871e8db71657b2a9816708141f121d767d3 Signed-off-by: Jeremy Compostella jeremy.compostella@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/70278 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Tarun Tuli taruntuli@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/pc80/vga/Kconfig M src/drivers/pc80/vga/Makefile.inc 2 files changed, 35 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, but someone else must approve Jérémy Compostella: Looks good to me, but someone else must approve Tarun Tuli: Looks good to me, approved
diff --git a/src/drivers/pc80/vga/Kconfig b/src/drivers/pc80/vga/Kconfig index 7da71af..0df65bc 100644 --- a/src/drivers/pc80/vga/Kconfig +++ b/src/drivers/pc80/vga/Kconfig @@ -2,3 +2,8 @@ bool help Include legacy VGA support code. + +config ROMSTAGE_VGA + bool + help + Include legacy VGA support code in romstage. diff --git a/src/drivers/pc80/vga/Makefile.inc b/src/drivers/pc80/vga/Makefile.inc index 3e31de1..f7ec2b5 100644 --- a/src/drivers/pc80/vga/Makefile.inc +++ b/src/drivers/pc80/vga/Makefile.inc @@ -1,5 +1,10 @@ ifeq ($(CONFIG_ARCH_X86),y)
+romstage-$(CONFIG_ROMSTAGE_VGA) += vga_io.c +romstage-$(CONFIG_ROMSTAGE_VGA) += vga_palette.c +romstage-$(CONFIG_ROMSTAGE_VGA) += vga_font_8x16.c +romstage-$(CONFIG_ROMSTAGE_VGA) += vga.c + ramstage-$(CONFIG_VGA) += vga_io.c ramstage-$(CONFIG_VGA) += vga_palette.c ramstage-$(CONFIG_VGA) += vga_font_8x16.c