Idwer Vollering has uploaded this change for review.

View Change

southbridge/amd: deduplicate MMIO macro [WIP]

This touches several mainboards, by moving the macro to a header file.
The presence of bootblock.c is assumed.

Change-Id: I583034ef0b0ed3e5a5e3dd680c57728ec5efbc8f
Signed-off-by: Idwer Vollering <vidwer@gmail.com>
---
M src/mainboard/asus/f2a85-m/bootblock.c
M src/southbridge/amd/common/amd_defs.h
2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/37738/1

diff --git a/src/mainboard/asus/f2a85-m/bootblock.c b/src/mainboard/asus/f2a85-m/bootblock.c
index 648f55a..ce82d0e 100644
--- a/src/mainboard/asus/f2a85-m/bootblock.c
+++ b/src/mainboard/asus/f2a85-m/bootblock.c
@@ -23,8 +23,6 @@
 #include <superio/nuvoton/common/nuvoton.h>
 #include <superio/nuvoton/nct6779d/nct6779d.h>
 
-#define SB_MMIO_MISC32(x) *(volatile u32 *)(AMD_SB_ACPI_MMIO_ADDR + 0xE00 + (x))
-
 static void sbxxx_enable_48mhzout(void)
 {
 	/* most likely programming to 48MHz out signal */
diff --git a/src/southbridge/amd/common/amd_defs.h b/src/southbridge/amd/common/amd_defs.h
index 55db30f..d3657c9 100644
--- a/src/southbridge/amd/common/amd_defs.h
+++ b/src/southbridge/amd/common/amd_defs.h
@@ -19,4 +19,6 @@
 
 #define AMD_SB_ACPI_MMIO_ADDR 0xfed80000ul
 
+#define SB_MMIO_MISC32(x) *(volatile u32 *)(AMD_SB_ACPI_MMIO_ADDR + 0xE00 + (x))
+
 #endif

To view, visit change 37738. To unsubscribe, or for help writing mail filters, visit settings.