View Change

8 comments:

• Commit Message:

  • Patch Set #6, Line 9: make suspend fail.

    fail suspend/resume.

  • Patch Set #6, Line 9: 26M clock will be hold by srcclkena

    SRCCLKENA holds 26M clock

  • Patch Set #6, Line 10: on

    by

  • Patch Set #6, Line 10: , so we release it.

    so we can simply release it for suspend/resume to work.

  • Patch Set #6, Line 10: srcclkena

    SRCCLKENA

• File src/soc/mediatek/mt8183/md_ctrl.c:

  • Patch Set #6, Line 23: (1 << 8) | (1 << 9)

    Do these have good reg constant names?

    If possible, please define them as enum (can be in the .c file), and then use the named constant here to make it more meaningful.

  • Patch Set #6, Line 25: 0xFF

    also make a constant for this.

• File src/soc/mediatek/mt8183/soc.c:

  • Patch Set #6, Line 20: #include <soc/md_ctrl.h>

    order header files (i.e., move to before mmu_operations.h

To view, visit change 32666. To unsubscribe, or for help writing mail filters, visit settings.