6 comments:
File src/mainboard/clevo/cml-u/Kconfig:
Patch Set #34, Line 14: # select MAINBOARD_HAS_LIBGFXINIT
if libgfxinit doesn't support CML, then this should be dropped
Patch Set #34, Line 18: ONBOARD_VGA_IS_PRIMARY
is this needed?
File src/mainboard/clevo/cml-u/Makefile.inc:
Patch Set #34, Line 8: ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += variants/$(VARIANT_DIR)/gma-mainboard.ads
if libgfxinit doesn't support CML, then this should be dropped
File src/mainboard/clevo/cml-u/ramstage.c:
/*
* TODO:
* - Add kill switches for WLAN, BT, LTE, CCD
* - Add support for WoL (LAN, WLAN)
* - Make M.2 port configurable (SATA <> PCIe)
* - Make SATA DevSlp configurable
* - Make TBT port configurable (TBT <> DisplayPort)
*/
generally this is less than ideal unless there's a specific reason these haven't been implemented
File src/mainboard/clevo/cml-u/variants/n141cu/gma-mainboard.ads:
Patch Set #34, Line 1: -- SPDX-License-Identifier: GPL-2.0-or-later
if libgfxinit doesn't support CML, then this should be dropped.
also, doubtful the board actually has all these ports present
File src/mainboard/clevo/cml-u/variants/n141cu/include/gpio_table.h:
Patch Set #34, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
assume this is just taken from an inteltool dump? the 2nd data word should be & 0xff00 and can be truncated to 4 bytes for readability. And the RSVD GPIOs don't need to be programmed AIUI.
To view, visit change 40581. To unsubscribe, or for help writing mail filters, visit settings.