Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31844 )
Change subject: google/kukui: Enable CHROMEOS_USE_EC_WATCHDOG_FLAG ......................................................................
Patch Set 12: Code-Review-1
(2 comments)
https://review.coreboot.org/c/coreboot/+/31844/12/src/mainboard/google/kukui... File src/mainboard/google/kukui/Kconfig:
https://review.coreboot.org/c/coreboot/+/31844/12/src/mainboard/google/kukui... PS12, Line 22: config CHROMEOS : def_bool y no we can't do this.
CHROMEOS should be always default y on coreboot. It's chromeos (portage) that will be using CHROMEOS option.
https://review.coreboot.org/c/coreboot/+/31844/12/src/mainboard/google/kukui... PS12, Line 35: CHROMEOS_USE_EC_WATCHDOG_FLAG one alternative is
select CHROMEOS_USE_EC_WATCHDOG_FLAG if CHROMEOS