Attention is currently required from: Ana Carolina Cabral.
Nick Kochlowski has posted comments on this change by Ana Carolina Cabral. ( https://review.coreboot.org/c/coreboot/+/85493?usp=email )
Change subject: mb/amd/birman_plus: Kconfig
......................................................................
Patch Set 12:
(2 comments)
File src/mainboard/amd/birman_plus/port_descriptors_glinda.c:
https://review.coreboot.org/c/coreboot/+/85493/comment/5e184677_2e8233cc?usp... :
PS12, Line 42: \
Not sure what the rule is or if it is important, but should the backslash be aligned with the others?
https://review.coreboot.org/c/coreboot/+/85493/comment/b9336f37_b3d4ddc0?usp... :
PS12, Line 44: 15
Should this value depend on ENABLE_WLAN02_BIRMANPLUS like in patchset 8? Same for 2-lane WWAN
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85493?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia310ea616006479b9a052afb99d08df6a11431f4
Gerrit-Change-Number: 85493
Gerrit-PatchSet: 12
Gerrit-Owner: Ana Carolina Cabral
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-CC: Nick Kochlowski
nickkochlowski@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ana Carolina Cabral
Gerrit-Comment-Date: Thu, 16 Jan 2025 13:48:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
