Attention is currently required from: Arthur Heymans, Jérémy Compostella.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79738?usp=email )
Change subject: smmstorev2: Load the communication buffer at SMM setup
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/include/cpu/x86/smm.h:
https://review.coreboot.org/c/coreboot/+/79738/comment/1f7ea6f6_12530231 :
PS2, Line 94: SMMSTORE_V2
can we get rid of preprocessor guards by using a 0-sized variable when the condition isn't true?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79738?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I94dce77711f37f87033530f5ae48cb850a39341b
Gerrit-Change-Number: 79738
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 28 Dec 2023 06:48:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment