5 comments:
File src/mainboard/google/kukui/mainboard.c:
Patch Set #1, Line 48: "sspm"
Don't directly use string literal as file name.
Could I use sspm.img?
File src/soc/mediatek/mt8183/Makefile.inc:
Patch Set #1, Line 52: ramstage-y += sspm.c
move this line in between line 47~48
Why? I think it is in-order in line 52 ?
File src/soc/mediatek/mt8183/include/soc/sspm.h:
Patch Set #1, Line 26: #define CFG_SSPM_SRAM 0x10400000
How about we move it to addresmap. […]
I will move it to addresmap.h, and re-name to SSPM_SRAM_BASE
File src/soc/mediatek/mt8183/sspm.c:
Patch Set #1, Line 22: #define SSPM_UART 1
this should be a Kconfig value
It is about pin selection depends on platform and just for debug.
I will remove it in formal code.
Patch Set #1, Line 31: write32
a command for what this triggers - resetting SSPM ? or also loads the CFG_SSPM_SRAM etc?
resetting SSPM
To view, visit change 31516. To unsubscribe, or for help writing mail filters, visit settings.