Nice, thank you for upstreaming this.
Already use SPDX headers?
18 comments:
Patch Set #13, Line 7: src/mainboard/libretrend/lt1000: Initial commit
Please use just `mb/libretrend/lt1000:`, and use a statement by adding a verb in imperative mood.
mb/libretrend/lt1000: Do initial commit
or
mb/libretrend: Add KBL based Libretrend LT1000 (Librebox)
Please add a note, how you created that board.
Note, that Libretrend contracted(?) the work?
File Documentation/mainboard/libretrend/lt1000.md:
Patch Set #13, Line 23: Kabylake
Kaby Lake
Patch Set #13, Line 25: *3rdparty/fsp* submodule.
Mark up as code `3rdparty/fsp`.
Patch Set #13, Line 27: microcode
Microcode updates are …
Patch Set #13, Line 28: from the *3rdparty/intel-microcode* submodule.
Mark up as code/monospace.
, whose datasheet
can be found [here][W25Q64FV]
Just do [datasheet][W25Q64FV].
Patch Set #13, Line 47: Fastboot
What is that?
File src/mainboard/libretrend/lt1000/acpi/mainboard.asl:
Looks like a lot of boards use that, so it should be put in some common location.
Patch Set #13, Line 21: Name (PBST, One)
What is this good for?
File src/mainboard/libretrend/lt1000/bootblock.c:
What about port 2?
File src/mainboard/libretrend/lt1000/mainboard.c:
Please add spaces around the 0.
Patch Set #13, Line 47: MAX_SERIAL_LENGTH);
Fits in 96 characters.
File src/mainboard/libretrend/lt1000/ramstage.c:
Remove.
https://doc.coreboot.org/coding_style.html#commenting
File src/mainboard/libretrend/lt1000/romstage.c:
Patch Set #13, Line 38: /* DQS CPU<>DRAM map
https://doc.coreboot.org/coding_style.html#commenting
Patch Set #13, Line 50: /* Rcomp resistor */
Unneeded comment.
Patch Set #13, Line 53: sizeof(RcompResistor));
One line.
https://doc.coreboot.org/coding_style.html#commenting
To view, visit change 30360. To unsubscribe, or for help writing mail filters, visit settings.