This change looks to require CSTE (Current Display State), NSTE (Next Display State) and DSEN (Display Output Switching Enable) added to globalnvs and the SMI trap added back to platform (https://github.com/coreboot/coreboot/commit/2e37fdddd5f859b82923485612ec869325f149fc)

Hmmm, maybe we should fix the common code first. a) The GNVS variables are never
referenced anywhere else, hence could be local variables in `gma/acpi/common.asl`.
b) The TRAP only makes sense if there is an SMI handler to handle it. Maybe we
should identify the platforms that do that and disable the call on the others.

View Change

1 comment:

• File src/drivers/intel/gma/acpi/new-pch.asl:

  • Patch Set #1:

    Are you referring to CB:32529 and CB:32549?

    The former probably. I've seen earlier patches too,not sure if anything was
    merged.

To view, visit change 31503. To unsubscribe, or for help writing mail filters, visit settings.