[coreboot-gerrit] Change in coreboot[master]: intel/skylake: Implement PCIe RP devicetree update based on LCAP

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35985 )

Change subject: intel/skylake: Implement PCIe RP devicetree update based on LCAP
......................................................................

Patch Set 18:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35985/14/src/soc/intel/skylake/chip... 
File src/soc/intel/skylake/chip.c:

https://review.coreboot.org/c/coreboot/+/35985/14/src/soc/intel/skylake/chip... 
PS14, Line 49: offset = 8, .count = 4
> Yeah, right, but we do check if it's enabled/available. […]

Ah, "8 is the maximum per PCI device." -> so it's PCI spec? Then why not simply drop `.count`? As you already comment below, "probing 4 non-existent ports shouldn't hurt" :-)