View Change

4 comments:

• Commit Message:

  • Patch Set #1, Line 16: collapsable

    collapsible

    Done

  • Patch Set #1, Line 18: Also clarified

    Also, clarified […]

    I disagree. The "also" is not conjunctive here. Instead, this sentence is a shortened form of "I also clarified ...", so there should be no comma.

• File src/lib/string.c:

  • Patch Set #1, Line 50:

    char *strchr(const char *s, int c)
    {
    	for (; *s; s++) {
    		if (*s == c)
    			return (char *)s;
    	}
    	return NULL;
    }
    
    char *strrchr(const char *s, int c)
    {
    	char *p = NULL;
    
    	for (; *s; s++)
    		if (*s == c)
    			p = (char *)s;
    
    	return p;
    }
    

    These two seem wrong. […]

    True, that's a bug in the old implementations already. Fixed.

  • Patch Set #1, Line 72:

    register char *ret = to;
    	register char data;
    

    `register` is an anachronism, better just drop it

    Sure... I mean, I just moved the existing implementations around here. But I can take it out if you want.

To view, visit change 32901. To unsubscribe, or for help writing mail filters, visit settings.