Angel Pons has uploaded this change for review.

View Change

cpu/amd/{agesa,pi}: Factor out common settings

Change-Id: I1dbf7514f8fa1a66eeb8a9e7c737df2667bb878b
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
---
M src/cpu/amd/agesa/Kconfig
M src/cpu/amd/agesa/family14/Kconfig
M src/cpu/amd/agesa/family15tn/Kconfig
M src/cpu/amd/agesa/family16kb/Kconfig
M src/cpu/amd/pi/00630F01/Kconfig
M src/cpu/amd/pi/00660F01/Kconfig
M src/cpu/amd/pi/00730F01/Kconfig
M src/cpu/amd/pi/Kconfig
8 files changed, 12 insertions(+), 36 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/44233/1
diff --git a/src/cpu/amd/agesa/Kconfig b/src/cpu/amd/agesa/Kconfig
index 499cc5b..f8b924f 100644
--- a/src/cpu/amd/agesa/Kconfig
+++ b/src/cpu/amd/agesa/Kconfig
@@ -10,6 +10,12 @@
select ARCH_VERSTAGE_X86_32
select ARCH_ROMSTAGE_X86_32
select ARCH_RAMSTAGE_X86_32
+ select CPU_X86_CACHE
+ select CPU_X86_LAPIC
+ select CPU_X86_MTRR
+ select CPU_X86_SMM
+ select CPU_X86_TSC
+ select X86_AMD_FIXED_MTRRS
select DRIVERS_AMD_PI
select TSC_SYNC_LFENCE
select UDELAY_LAPIC
diff --git a/src/cpu/amd/agesa/family14/Kconfig b/src/cpu/amd/agesa/family14/Kconfig
index 8667602..7fc917a 100644
--- a/src/cpu/amd/agesa/family14/Kconfig
+++ b/src/cpu/amd/agesa/family14/Kconfig
@@ -2,12 +2,6 @@

config CPU_AMD_AGESA_FAMILY14
bool
- select CPU_X86_CACHE
- select CPU_X86_LAPIC
- select CPU_X86_MTRR
- select CPU_X86_SMM
- select CPU_X86_TSC
- select X86_AMD_FIXED_MTRRS

if CPU_AMD_AGESA_FAMILY14

diff --git a/src/cpu/amd/agesa/family15tn/Kconfig b/src/cpu/amd/agesa/family15tn/Kconfig
index 4b6b40e..eb267df 100644
--- a/src/cpu/amd/agesa/family15tn/Kconfig
+++ b/src/cpu/amd/agesa/family15tn/Kconfig
@@ -2,12 +2,6 @@

config CPU_AMD_AGESA_FAMILY15_TN
bool
- select CPU_X86_CACHE
- select CPU_X86_LAPIC
- select CPU_X86_MTRR
- select CPU_X86_SMM
- select CPU_X86_TSC
- select X86_AMD_FIXED_MTRRS

if CPU_AMD_AGESA_FAMILY15_TN

diff --git a/src/cpu/amd/agesa/family16kb/Kconfig b/src/cpu/amd/agesa/family16kb/Kconfig
index 1b43dbe..3342984 100644
--- a/src/cpu/amd/agesa/family16kb/Kconfig
+++ b/src/cpu/amd/agesa/family16kb/Kconfig
@@ -2,12 +2,6 @@

config CPU_AMD_AGESA_FAMILY16_KB
bool
- select CPU_X86_CACHE
- select CPU_X86_LAPIC
- select CPU_X86_MTRR
- select CPU_X86_SMM
- select CPU_X86_TSC
- select X86_AMD_FIXED_MTRRS

if CPU_AMD_AGESA_FAMILY16_KB

diff --git a/src/cpu/amd/pi/00630F01/Kconfig b/src/cpu/amd/pi/00630F01/Kconfig
index db921c3..b811f87 100644
--- a/src/cpu/amd/pi/00630F01/Kconfig
+++ b/src/cpu/amd/pi/00630F01/Kconfig
@@ -2,12 +2,6 @@

config CPU_AMD_PI_00630F01
bool
- select CPU_X86_CACHE
- select CPU_X86_LAPIC
- select CPU_X86_MTRR
- select CPU_X86_SMM
- select CPU_X86_TSC
- select X86_AMD_FIXED_MTRRS

if CPU_AMD_PI_00630F01

diff --git a/src/cpu/amd/pi/00660F01/Kconfig b/src/cpu/amd/pi/00660F01/Kconfig
index 859dda0..d56b063 100644
--- a/src/cpu/amd/pi/00660F01/Kconfig
+++ b/src/cpu/amd/pi/00660F01/Kconfig
@@ -2,12 +2,6 @@

config CPU_AMD_PI_00660F01
bool
- select CPU_X86_CACHE
- select CPU_X86_LAPIC
- select CPU_X86_MTRR
- select CPU_X86_SMM
- select CPU_X86_TSC
- select X86_AMD_FIXED_MTRRS

if CPU_AMD_PI_00660F01

diff --git a/src/cpu/amd/pi/00730F01/Kconfig b/src/cpu/amd/pi/00730F01/Kconfig
index c8c6e0a..96faa64 100644
--- a/src/cpu/amd/pi/00730F01/Kconfig
+++ b/src/cpu/amd/pi/00730F01/Kconfig
@@ -2,12 +2,6 @@

config CPU_AMD_PI_00730F01
bool
- select CPU_X86_CACHE
- select CPU_X86_LAPIC
- select CPU_X86_MTRR
- select CPU_X86_SMM
- select CPU_X86_TSC
- select X86_AMD_FIXED_MTRRS
select SUPPORT_CPU_UCODE_IN_CBFS
select MICROCODE_BLOB_UNDISCLOSED

diff --git a/src/cpu/amd/pi/Kconfig b/src/cpu/amd/pi/Kconfig
index 533507e..968431d 100644
--- a/src/cpu/amd/pi/Kconfig
+++ b/src/cpu/amd/pi/Kconfig
@@ -10,6 +10,12 @@
select ARCH_VERSTAGE_X86_32
select ARCH_ROMSTAGE_X86_32
select ARCH_RAMSTAGE_X86_32
+ select CPU_X86_CACHE
+ select CPU_X86_LAPIC
+ select CPU_X86_MTRR
+ select CPU_X86_SMM
+ select CPU_X86_TSC
+ select X86_AMD_FIXED_MTRRS
select DRIVERS_AMD_PI
select TSC_SYNC_LFENCE
select UDELAY_LAPIC

To view, visit change 44233. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1dbf7514f8fa1a66eeb8a9e7c737df2667bb878b
Gerrit-Change-Number: 44233
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: newchange