View Change

1 comment:

• File src/security/vboot/common.c:

  • Patch Set #1, Line 48: #if ENV_POSTCAR || ENV_RAMSTAGE

    The reason I used preprocessor conditionals -- […]

    The region where _vboot2_work resides is torn down on certain platforms. It doesn't just continue to exist. You have to be more careful with the C conditionals.

    cbmem_possibly_online() is your friend for postcar and ramstage as well as odd conditionals for verstage being ran after romstage (separate stage vs linked matters here as well).

    I believe nearly all this similar logic was already handled in here or vboot_logic since it needs to deal with most of those cases.

To view, visit change 31329. To unsubscribe, or for help writing mail filters, visit settings.