4 comments:
File src/soc/intel/apollolake/memmap.c:
Patch Set #29, Line 39: #ifdef SOC_INTEL_COMMON_BLOCK_SGX_PRMRR_SIZE
Why wouldn't you provide a default value of 0 for this macro?
if you had looked into get_max_prmrr_size(), you'd know ;) get_max_prmrr_size has a parameter `limit`, while limit=0 means "no limit"
File src/soc/intel/common/block/sgx/Kconfig:
Patch Set #29, Line 40: depends on SOC_INTEL_CANNONLAKE_BASE || SOC_INTEL_ICELAKE
So are we going to try and maintain this list here (and in multiple places?). […]
what do you mean with "and in multiple places"?
Patch Set #29, Line 53: depends on !SOC_INTEL_COMMON_BLOCK_SGX_ENABLE
Why is the 1MiB carved out from SGX_ENABLE Kconfig?
Because SGX depends on PRMRR >= 32 MiB
File src/soc/intel/skylake/memmap.c:
readability? can remove it if you insist
superseeded
To view, visit change 35799. To unsubscribe, or for help writing mail filters, visit settings.