Patch set 8:Code-Review +2
4 comments:
Patch Set #7, Line 124: return car_get_ptr(glob_ts_table);
Why would he have cbmem_find() here now, see patchset #3 comment? I thought you analyzed for ramstag […]
Right, I guess we don't need cbmem_find() because CBMEM recovery always sets the pointer already.
Patch Set #8, Line 74: static struct timestamp_cache *timestamp_cache_get(void)
nit: Now that there are no other relevant members in struct timestamp_cache, you could change this to return &ts_cache->table...
Patch Set #8, Line 131: ts_cache = timestamp_cache_get();
...and then simplify this to just
ts_table = timestamp_cache_get();
Patch Set #8, Line 203: if (!ENV_ROMSTAGE_OR_BEFORE)
nit: Should this maybe just be an assert()? Because doing this is just incorrect now, right? We can fix the code that does this instead.
To view, visit change 35032. To unsubscribe, or for help writing mail filters, visit settings.