Sorry for being late here. Some information from a non-vboot user:

We have our update process in the payload, it checks the id of an
image to flash. It's expected at the end of CBFS as it was there
for more than a decade (on x86). If we remove it there, we might
have to revert this downstream to stay compatible with our current
production firmware, but only if we decided to jump to a newer
branch for an existing product (unlikely).

Nevertheless, I don't think we should remove this without a more
public discussion. There may be more coreboot ecosystem using it
than we know.

I haven't looked into the implementation here, but the idea of an
FMAP region seems odd: The id section used to contain a version,
don't we have multiple versions in one image in case of vboot?
Wouldn't that need an FMAP region per RO/RW slot to be consistent?

If we want to unify things, I would propose to put it at the end
of each CBFS. So far, every CBFS seems to comprise one version
of coreboot. Why at the end? well, it's already there on x86 (non-
reset-vector-in-ram case), and I don't expect it to collide in
other cases.

Another thought, if we want to get rid of this legacy, x86
location, but keep the id, how about adding a simple file to
CBFS as standard from now on, and keeping the legacy id in
the bootblock for a few releases until users adapted?

View Change

To view, visit change 40377. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe1aaf36bec00b4cffc46a3640a5a0d1e4bb8067
Gerrit-Change-Number: 40377
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks@eltan.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com>
Gerrit-Reviewer: Wim Vervoorn <wvervoorn@eltan.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Fri, 24 Apr 2020 20:25:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment