Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35985 )
Change subject: soc/intel: Implement PCIe RP devicetree update based on LCAP ......................................................................
Patch Set 19:
(4 comments)
Kyösti, now that turned to unlink device nodes, could you have a look at that?
https://review.coreboot.org/c/coreboot/+/35985/17/src/soc/intel/common/block... File src/soc/intel/common/block/pcie/pcie_rp.c:
https://review.coreboot.org/c/coreboot/+/35985/17/src/soc/intel/common/block... PS17, Line 102: dev->enabled = 0;
I thought about unlinking these nodes from the bus. And now I'm […]
Done
https://review.coreboot.org/c/coreboot/+/35985/18/src/soc/intel/common/block... File src/soc/intel/common/block/pcie/pcie_rp.c:
https://review.coreboot.org/c/coreboot/+/35985/18/src/soc/intel/common/block... PS18, Line 160: *ptr = dev->sibling;
The former, yes, the latter, no. […]
Done
https://review.coreboot.org/c/coreboot/+/35985/18/src/soc/intel/common/block... PS18, Line 161: dev->sibling
No. The next step is either leaving the function and destroying the stack frame including […]
Done
https://review.coreboot.org/c/coreboot/+/35985/18/src/soc/intel/common/block... PS18, Line 162: }
Missed to update `ptr` on the else path...
Done