Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak. Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47684 )
Change subject: soc/tigerlake: Fix TCSS code to calling back and forth to mainboard and soc ......................................................................
Patch Set 6:
(6 comments)
File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/47684/comment/76fa83b7_9b67f4dd PS5, Line 2:
#include <bootmode.h> […]
Done
https://review.coreboot.org/c/coreboot/+/47684/comment/e8bf01fc_e1ed403f PS5, Line 268: struct
const […]
Done
https://review.coreboot.org/c/coreboot/+/47684/comment/031922e0_637289dc PS5, Line 268: NULL
Not required. This is set on line 275.
Done
File src/soc/intel/tigerlake/include/soc/early_tcss.h:
https://review.coreboot.org/c/coreboot/+/47684/comment/bf33ca3d_55e08460 PS5, Line 129: //void update_tcss_mux(int port, struct tcss_mux mux_data);
Drop commented out code.
Done
https://review.coreboot.org/c/coreboot/+/47684/comment/3da31381_c1edffa4 PS5, Line 134: Weak mainboard method to setup any mux configuration needed for early TCSS operations. : * This function will need to obtain any mux data needed to forward to IOM/PMC and call : * the update_tcss_mux method which will call any PMC commands needed to connect the : * ports. Since the mux data may be stored differently by different mainboards this : * must be overridden by the mainboard with its specific mux data stored in a struct tcss_mux : * struct as defined above.
Comment needs update.
Done
https://review.coreboot.org/c/coreboot/+/47684/comment/cf2049d7_77ae95c0 PS5, Line 142: mainboard_tcssfill_mux_info
This doesn't match the name in early_tcss. […]
Done