Thanks Yu-Ping support, and Hung-Te/Julius review this patch.

View Change

3 comments:

• File src/soc/mediatek/mt8183/spm.c:

  • Patch Set #53, Line 268: dyna_load_pcm[index].buf);

    @dawei Please respond to this.

    It is just for debug purpose only.
    (If we meet issue, we might know address and dump whole dram context by ICE/T32)
    Actually I agree that we don't really need it, we can remove it.

  • Patch Set #53, Line 270: /* start of pcm_desc */

    @dawei Any comment on this?

    Do you mean if we could use the other format to package this FW? If yes, sorry that please understand that we really can't change it since it was a fixed version for few years.

  • Patch Set #53, Line 291: printk(BIOS_INFO, "%s done after %ld msecs.\n", __func__,

    @dawei Please address this.

    Could we change all INFO to DEBUG here, and I could remove function name and line as well.

To view, visit change 34545. To unsubscribe, or for help writing mail filters, visit settings.