6 comments:
File Documentation/mainboard/51nb/x210.md:
Patch Set #24, Line 1: # 51NB X210
file needs to be referenced by index. […]
Ack
I would suggest explaining how to flash internally using a layout/fmap, for images built without EC […]
Ack
Patch Set #24, Line 19: is located on the upper side of the motherboard, below the keyboard
can you provide a picture? […]
Ack
File src/ec/51nb/npce985la0dx/Kconfig:
Patch Set #23, Line 27: images
Minor: there's just one image, so this should be singular
Ack
Patch Set #23, Line 29: default y
Since you're using a fmap in coreboot, you can use it with flashrom to flash only to the FMAP's BIOS […]
Ack
File src/ec/51nb/npce985la0dx/npce985la0dx.c:
Patch Set #24, Line 19: { NULL, 0x05 }, { NULL, 0x06 }, { NULL, 0x11 }
what are those LDNs used for? Do you need to set additional registers in the superio space?
Ack
To view, visit change 32531. To unsubscribe, or for help writing mail filters, visit settings.