HAOUAS Elyes has uploaded this change for review.

View Change

nb/i945: Drop unneeded loop

At sdram_power_management() function, MCHBAR32(UPMC3) bit 16 is already set.

Change-Id: Iefa53ceaa4fb9dd7868ea59a21d9bd11f3bf27b9
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
---
M src/northbridge/intel/i945/raminit.c
1 file changed, 0 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/40369/1
diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c
index dad1cb2..4353a9c 100644
--- a/src/northbridge/intel/i945/raminit.c
+++ b/src/northbridge/intel/i945/raminit.c
@@ -2147,7 +2147,6 @@
u16 reg16;
u32 reg32;
int integrated_graphics = pci_read_config16(PCI_DEV(0, 0x00, 0), GGC) & 2;
- int i;

reg32 = MCHBAR32(C0DRT2);
reg32 &= 0xffffff00;
@@ -2193,11 +2192,6 @@

MCHBAR32(UPMC3) = 0x000f06ff;

- for (i = 0; i < 5; i++) {
- MCHBAR32(UPMC3) &= ~(1 << 16);
- MCHBAR32(UPMC3) |= (1 << 16);
- }
-
MCHBAR32(GIPMC1) = 0x8000000c;

reg16 = MCHBAR16(CPCTL);

To view, visit change 40369. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iefa53ceaa4fb9dd7868ea59a21d9bd11f3bf27b9
Gerrit-Change-Number: 40369
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-MessageType: newchange