Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35985 )
Change subject: intel/skylake: Implement PCIe RP devicetree update based on LCAP
......................................................................
Patch Set 18:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35985/14/src/soc/intel/skylake/chip...
File src/soc/intel/skylake/chip.c:
https://review.coreboot.org/c/coreboot/+/35985/14/src/soc/intel/skylake/chip...
PS14, Line 83: if (CONFIG(SKYLAKE_SOC_PCH_H))
: pcie_rp_update_devicetree(pch_h_rp_groups);
: else
: pcie_rp_update_devicetree(pch_lp_rp_groups);
:
We already do that for every port. If it wasn't set to root port, it would
we invalid to read LCAP :)
\o/ ofc. I read the datasheet but didn't look at the code again before commenting :D thanks
Well, we know that LP doesn't have 1b.*, so it's safe. One version is more explicit, the other saves us a few lines. I have no strong preference.
Since we already have the checks I mentioned, I would prefer having just one list, but having two isn't bad, too. I don't know. @Arthur what do you say?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35985
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib17d2b6fd34608603db3936d638bdf5acb46d717
Gerrit-Change-Number: 35985
Gerrit-PatchSet: 18
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 09 Nov 2019 08:27:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment