Patch set 1:Code-Review +1
View Change
1 comment:
File src/Kconfig:
Patch Set #1, Line 1220: depends on NO_XIP_EARLY_STAGES
I'm not sure it's worth the overhead in bootblock and all stages needing to carry compression code a […]
LZ4 is really tiny (on the order of a few hundred bytes). Even with a 20k romstage and an 80% compression ratio, you're coming out way ahead (and real numbers should be much better than that).
To view, visit change 36613. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iac24d243c4bd4cb8c1db14a8e9fc43f508c2cd5d
Gerrit-Change-Number: 36613
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin@chromium.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-Comment-Date: Mon, 04 Nov 2019 21:15:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Aaron Durbin <adurbin@chromium.org>
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment