Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
Doc/mb/lenovo/montevina_series: Use Makefile to generate IFD

util/bincfg's Makefile already has target that generates flash
descriptor. Use it instead.

Change-Id: I1756514e1ab7b64de23a98314d8a32e9258e648c
Signed-off-by: Evgeny Zinoviev <me@ch1p.io>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39762
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
M Documentation/mainboard/lenovo/montevina_series.md
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Documentation/mainboard/lenovo/montevina_series.md b/Documentation/mainboard/lenovo/montevina_series.md
index f3aca04..529fec6 100644
--- a/Documentation/mainboard/lenovo/montevina_series.md
+++ b/Documentation/mainboard/lenovo/montevina_series.md
@@ -112,9 +112,11 @@

Then create the flash descriptor:
```console
-$ ./bincfg ifd-x200.spec ifd-x200.set ifd.bin
+$ make gen-ifd-x200
```

+It will be saved to the `flashregion_0_fd.bin` file.
+
#### Configuring coreboot

Now configure coreboot. You need to select correct chip size and specify paths
@@ -127,7 +129,7 @@

Chipset --->
[*] Add Intel descriptor.bin file
- # Note: if you used bincfg, specify path to generated util/bincfg/ifd.bin
+ # Note: if you used bincfg, specify path to generated util/bincfg/flashregion_0_fd.bin
(/path/to/flashregion_0_flashdescriptor.bin) Path and filename of the descriptor.bin file

[*] Add gigabit ethernet configuration

To view, visit change 39762. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1756514e1ab7b64de23a98314d8a32e9258e648c
Gerrit-Change-Number: 39762
Gerrit-PatchSet: 3
Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Swift Geek (Sebastian Grzywna) <swiftgeek@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged