Patch Set 5:

Patch Set 5:

Random thought: Couldn't this be factored out into drivers instead?

I initially had that thought. But some of the things here are more APIs than hardware management/configuration. I can see that the drivers enable configuring the device through device tree and export ACPI objects for use by kernel. I also thought about factoring into lib. But again the things here are more vendor/mainboard specific. Just my thoughts.

Lint check still seems to fail for mb/intel/common CLs, can I keep the Kconfig.name and board_info.txt for now? and remove once we have this CL merged?

View Change

To view, visit change 37705. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc6f9bd298520f5e929534c64f1b038a4c9684a9
Gerrit-Change-Number: 37705
Gerrit-PatchSet: 6
Gerrit-Owner: Aamir Bohra <aamir.bohra@intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela@intel.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Thu, 19 Dec 2019 04:48:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment