Attention is currently required from: Wonkyu Kim, Ethan Tsao, Ravishankar Sarawadi, Tim Wawrzynczak.
1 comment:
File util/ifdtool/ifdtool.c:
Patch Set #1, Line 227: PLATFORM_V1
IFD2 platform already have use many plaforms which is not same as TGL,ADL.
static const int ifd_2_platforms[] = {
PLATFORM_APL,
PLATFORM_GLK,
PLATFORM_CNL,
PLATFORM_LBG,
PLATFORM_ICL,
PLATFORM_TGL,
PLATFORM_JSL,
PLATFORM_EHL,
PLATFORM_ADL,
PLATFORM_SKLKBL,
PLATFORM_V1,
};Will PLATFORM_IFD2_COMMON_V1 is better?
I don't know what you have mind when you said "V1" ? for sure these are IFDv2 chipsets.
I think if there is new change for new platform we can use PLATFORM_IFD2_COMMON_V2 like this.
IFD is just bloated with so many different changes and we need to clean it for sure so, I would not bother to create a placeholder further between IFDv2_v1 or IFDv2_v2 instead if it's new chipset and demands newer layer (which I don't see so far even on 2 generation of IA), we can always go for IFDv3 instead layering between v1 and v2 inside IFDv2.
In that case we can use "ifd2_common_v1" or "ifd2_v1" as platform string.
"ifd2" is enough IMO without layering.
What do you think?
To view, visit change 61576. To unsubscribe, or for help writing mail filters, visit settings.