Subrata Banik submitted this change.

View Change



4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals: Eric Lai: Looks good to me, approved Subrata Banik: Looks good to me, approved build bot (Jenkins): Verified V Sowmya: Looks good to me, approved
mb/google/brya/var/trulo: Update ISH GPIO config for tablet mode switch

This patch configures the GPIO pins for ISH to notify EC about the
tablet mode change in accordance with schematic_20240607.

BUG=b:347811875
TEST=Build and boot google/trulo. Placed the device in tabletmode & on
EC console,"tabletmode" command shows "tablet mode".

Change-Id: Id22e397e46b522428ffdabe34a445ed7e4fb6fc5
Signed-off-by: Varun Upadhyay <varun.upadhyay@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84351
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Subrata Banik <subratabanik@google.com>
Reviewed-by: V Sowmya <v.sowmya@intel.com>
Reviewed-by: Eric Lai <ericllai@google.com>
---
M src/mainboard/google/brya/variants/trulo/gpio.c
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mainboard/google/brya/variants/trulo/gpio.c b/src/mainboard/google/brya/variants/trulo/gpio.c
index 1651b08..ddbb0fb 100644
--- a/src/mainboard/google/brya/variants/trulo/gpio.c
+++ b/src/mainboard/google/brya/variants/trulo/gpio.c
@@ -122,7 +122,7 @@
/* D1 : ISH_GP1 ==> SOC_GSEN2_INT# */
PAD_CFG_NF(GPP_D1, NONE, DEEP, NF1),
/* D2 : ISH_GP2 ==> SEN_MODE_EC_PCH_INT_ODL */
- PAD_CFG_GPI_LOCK(GPP_D2, NONE, LOCK_CONFIG),
+ PAD_CFG_NF(GPP_D2, NONE, DEEP, NF1),
/* D3 : NC */
PAD_NC_LOCK(GPP_D3, NONE, LOCK_CONFIG),
/* D4 : NC */

To view, visit change 84351. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id22e397e46b522428ffdabe34a445ed7e4fb6fc5
Gerrit-Change-Number: 84351
Gerrit-PatchSet: 6
Gerrit-Owner: Varun Upadhyay <varun.upadhyay@intel.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot@google.com>
Gerrit-Reviewer: Eric Lai <ericllai@google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: V Sowmya <v.sowmya@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Jayvik Desai <jayvik@google.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Rishika Raj <rishikaraj@google.com>