mturney mturney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35495 )
Change subject: trogdor: initial mainboard + libpayload support ......................................................................
Patch Set 6:
(2 comments)
libpayload issues now resolved with this patch. mainboard items are still TBD, probably not till next Monday.
https://review.coreboot.org/c/coreboot/+/35495/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35495/4//COMMIT_MSG@7 PS4, Line 7: trogdor: initial mainboard + libpayload support
Agreed, libpayload should be split out. […]
Build failures occurred with Depthcharge not with Coreboot. This patch will only introduce mainboard support for trogdor.
https://review.coreboot.org/c/coreboot/+/35495/5/payloads/libpayload/drivers... File payloads/libpayload/drivers/serial/sc7180.c:
https://review.coreboot.org/c/coreboot/+/35495/5/payloads/libpayload/drivers... PS5, Line 34: void serial_console_init(void)
Please don't commit empty stubs where possible, just remove the CONFIG_LP_SC7180_SERIAL_CONSOLE=y fr […]
This early patch has now been removed.