1 comment:
File src/arch/x86/postcar_loader.c:
Patch Set #6, Line 162: postcar_frame_add_mtrr(pcf, addr, size, type);
Implementation of postcar_frame_add_mtrr() is capable of splitting the region to multiple MTRRs. Implementation of enable_top_of_dram_cache() is not. The approach proposed here adds new alignment requirements, so you cannot simply change calls from postcar_frame_add_mtrr() to postcar_frame_setup_top_of_dram_usage(), like your followup work seems to propose.
I believe that as we discussed dropping CPU_ADDR_BITS and cpu_phys_address_size() I recommended not to use set_var_mtrr() but to replay the values from the generated frame instead.
To view, visit change 34805. To unsubscribe, or for help writing mail filters, visit settings.