Attention is currently required from: Arthur Heymans, Nico Huber, Paul Menzel, Ravindra, Sridhar Siricilla, Subrata Banik, Michael Niewöhner, Patrick Rudolph.
7 comments:
Commit Message:
Patch Set #7, Line 15: XPPPC
`XPPC`
File src/soc/intel/common/block/acpi/cpu_hybrid.c:
Patch Set #7, Line 26: u8 global_cpu_type[MAX_CPU_COUNT];
please don't reach into other modules' data; use an accessor function
void __weak get_cpu_scaling_factor(u16 *big_core_scal_factor, u16 *small_core_scal_factor)
{
}
bool __weak cpu_is_nominal_freq_supported(void)
{
return 0;
}
I don't think the weak definitions are necessary; this file is already guarded by the Kconfig SOC_INTEL_COMMON_BLOCK_ACPI_CPU_HYBRID, so if an SoC selects that, then it also has to implement these methods as part of that contract.
`sizeof(scope)`
`sizeof(scope)`
File src/soc/intel/common/block/include/intelblocks/acpi.h:
Patch Set #7, Line 21: /* It gets scaling factor for small and big core */
Since this has to be implemented per-SoC, I'd add a comment that mentions that and also prefix it with `soc_`
Patch Set #7, Line 139: bool cpu_is_nominal_freq_supported(void);
Since this has to be implemented per-SoC, I'd add a comment that mentions that and also prefix it with `soc_`
To view, visit change 59359. To unsubscribe, or for help writing mail filters, visit settings.