4 comments:
File src/drivers/smmstore/ramstage.c:
could use APM_CNT here but you'd have to pass another register like edx.
File src/drivers/smmstore/smi.c:
Patch Set #14, Line 144: param
the eventual range_check() seems like it will implicitly catch null pointers, but it might be clearer if there was a check at the start since the handlers seem to pass raw EBX values.
File src/drivers/smmstore/store.c:
Patch Set #14, Line 450: // NOTE: Not really necessarry..
agreed, none of the other functions check this so either they all should or none.
Patch Set #14, Line 39: SMMSTORE of at least 256KiB of size
maybe add a compile time check of CONFIG_SMMSTORE_SIZE if CONFIG_SMMSTOREV2 is enabled.
To view, visit change 40520. To unsubscribe, or for help writing mail filters, visit settings.