Attention is currently required from: Ravi kumar, mturney mturney, Julius Werner.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47284 )
Change subject: sc7280: support bitbang UART w/gpio
......................................................................
Patch Set 30:
(1 comment)
Patchset:
PS30:
Please factor this out into common code.
```
$ diff -ru src/soc/qualcomm/sc7180/uart_bitbang.c src/soc/qualcomm/sc7280/uart_bitbang.c
--- src/soc/qualcomm/sc7180/uart_bitbang.c 2021-03-31 08:31:19.624634555 +0200
+++ src/soc/qualcomm/sc7280/uart_bitbang.c 2021-03-31 09:06:29.151067791 +0200
@@ -4,7 +4,7 @@
#include <gpio.h>
#include <boot/coreboot_tables.h>
-#define UART_TX_PIN GPIO(44)
+#define UART_TX_PIN GPIO(22)
void uart_fill_lb(void *data)
{
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47284
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6c70f917a59e233f6ea518d9c39f73fe84991c3
Gerrit-Change-Number: 47284
Gerrit-PatchSet: 30
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 31 Mar 2021 07:07:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment