25 comments:
File src/soc/qualcomm/qcs405/include/soc/cdp.h:
Patch Set #1, Line 36: unsigned smem_get_board_machtype(void);
Prefer 'unsigned int' to bare use of 'unsigned'
Patch Set #1, Line 89: SPI_CS_0 ,
space prohibited before that ',' (ctx:WxE)
Patch Set #1, Line 119: unsigned count;
Prefer 'unsigned int' to bare use of 'unsigned'
Patch Set #1, Line 124: unsigned base;
Prefer 'unsigned int' to bare use of 'unsigned'
Patch Set #1, Line 126: unsigned is_macsec;
Prefer 'unsigned int' to bare use of 'unsigned'
Patch Set #1, Line 127: unsigned mac_pwr0;
Prefer 'unsigned int' to bare use of 'unsigned'
Patch Set #1, Line 128: unsigned mac_pwr1;
Prefer 'unsigned int' to bare use of 'unsigned'
Patch Set #1, Line 129: unsigned mac_conn_to_phy;
Prefer 'unsigned int' to bare use of 'unsigned'
Patch Set #1, Line 172: unsigned int get_board_index(unsigned machid);
Prefer 'unsigned int' to bare use of 'unsigned'
Patch Set #1, Line 173: void ipq_configure_gpio(const gpio_func_data_t *gpio, unsigned count);
Prefer 'unsigned int' to bare use of 'unsigned'
File src/soc/qualcomm/qcs405/include/soc/iomap.h:
Patch Set #1, Line 49: #define writel_i(v,a) write32((void *)a, v)
space required after that ',' (ctx:VxV)
File src/soc/qualcomm/qcs405/uart.c:
Patch Set #1, Line 50: unsigned blsp_uart;
Prefer 'unsigned int' to bare use of 'unsigned'
Patch Set #1, Line 54: void ipq_configure_gpio(const gpio_func_data_t *gpio, unsigned count)
Prefer 'unsigned int' to bare use of 'unsigned'
Patch Set #1, Line 56: int i;
code indent should use tabs where possible
Patch Set #1, Line 56: int i;
please, no spaces at the start of a line
Patch Set #1, Line 58: for (i = 0; i < count; i++) {
code indent should use tabs where possible
Patch Set #1, Line 58: for (i = 0; i < count; i++) {
please, no spaces at the start of a line
Patch Set #1, Line 59: gpio_configure(gpio->gpio, gpio->func,
code indent should use tabs where possible
Patch Set #1, Line 59: gpio_configure(gpio->gpio, gpio->func,
please, no spaces at the start of a line
Patch Set #1, Line 60: gpio->pull, gpio->drvstr, gpio->enable);
code indent should use tabs where possible
Patch Set #1, Line 60: gpio->pull, gpio->drvstr, gpio->enable);
please, no spaces at the start of a line
Patch Set #1, Line 61: gpio++;
code indent should use tabs where possible
Patch Set #1, Line 61: gpio++;
please, no spaces at the start of a line
code indent should use tabs where possible
please, no spaces at the start of a line
To view, visit change 29964. To unsubscribe, or for help writing mail filters, visit settings.