Attention is currently required from: Furquan Shaikh, Kane Chen, Karthik Ramasubramanian.

Kane Chen uploaded patch set #5 to this change.

View Change

soc/intel/{adl,tgl,jsl}: Add smihandler_soc_disable_busmaster

If a power button SMI is triggered between where it is currently
enabled and before FSP-S exits, when the SMI handler disables
bus mastering for all devices, it inadvertently also disables
the PMC's I/O decoding, so the register write to actually go into
S5 does not succeed, and the system hangs.

This can be solved by skipping the PMC when disabling bus
mastering in the SMI handler, for which a callback,
smihandler_soc_disable_busmaster is provided.

BUG=b:186194102, b:186815114

Change-Id: I1cf5cf91ebad4a49df6679e01fc88ff60c81526c
Signed-off-by: Kane Chen <kane.chen@intel.corp-partner.google.com>
---
M src/soc/intel/alderlake/smihandler.c
M src/soc/intel/jasperlake/smihandler.c
M src/soc/intel/tigerlake/smihandler.c
3 files changed, 21 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/52873/5

To view, visit change 52873. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1cf5cf91ebad4a49df6679e01fc88ff60c81526c
Gerrit-Change-Number: 52873
Gerrit-PatchSet: 5
Gerrit-Owner: Kane Chen <kane.chen@intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Kane Chen <kane.chen@intel.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Rasheed Hsueh <rasheed.hsueh@lcfc.corp-partner.google.com>
Gerrit-CC: Stanley Wu <stanley1.wu@lcfc.corp-partner.google.com>
Gerrit-CC: Sunshine Chao <sunshine.chao@lcfc.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan@google.com>
Gerrit-Attention: Kane Chen <kane.chen@intel.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-MessageType: newpatchset