Thank you for the patch, but I am a little upset, that after two people signed off this commit, there are still coding style issues. The reviewers time is also valuable, so they should not have to be distracted with these simple issue.

Patch set 13:Code-Review -1

View Change

8 comments:

To view, visit change 39360. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8687bce4896d9fc17b2190b8d11618af3515cc1
Gerrit-Change-Number: 39360
Gerrit-PatchSet: 13
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya@intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com>
Gerrit-Reviewer: Divagar Mohandass <divagar.mohandass@intel.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela@intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha@intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan@google.com>
Gerrit-Comment-Date: Mon, 06 Apr 2020 14:45:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment