Thank you for the patch, but I am a little upset, that after two people signed off this commit, there are still coding style issues. The reviewers time is also valuable, so they should not have to be distracted with these simple issue.
Patch set 13:Code-Review -1
8 comments:
Patch Set #13, Line 12: Add ON and OFF logic as Power Rails are same for both sensor
Please format it as a list.
File src/mainboard/google/dedede/Kconfig:
Patch Set #13, Line 85: Select this option to enable camera ACPI support on the variant
Please add a dot/period at the end.
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam0.asl:
Patch Set #13, Line 4: * Copyright (C) 2020 Intel Corporation.
No dot/period at the end.
Patch Set #13, Line 46: STXS(GPP_D15)
Please use tabs. Where did you copy this from?
Patch Set #13, Line 54: Sleep(5)
What is the unit?
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl:
Patch Set #13, Line 4: * Copyright (C) 2020 Intel Corporation.
Ditto.
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/ipu_endpoints.asl:
Patch Set #13, Line 4: * Copyright (C) 2020 Intel Corporation.
Ditto.
Patch Set #13, Line 18: Name (EP00, Package (0x02)
Tabs.
To view, visit change 39360. To unsubscribe, or for help writing mail filters, visit settings.